Add eslint and prettier for js files #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done according to new eslint and prettier configurations
|
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
|
Cypress failing ;) |
|
We have to add some dependencies for cypress. Seems like Github's container is missing some packages that need to be installed manually. I'll read about how we can do so, but I guess we need a container of our own for it. https://docs.cypress.io/guides/guides/continuous-integration.html#Advanced-setup |
|
Sounds fun ^^ |
stp-ip
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added linter and fixer for JS files
The configuration uses airbnb base config which is the closest to our style and prettier cleans up the code and doesn't interfere with airbnb's linting rules.
Which issue this PR fixes:
fixes #698