Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing customised Formspree POST URL handling from the contact form #837

Merged
merged 1 commit into from Nov 13, 2020
Merged

removing customised Formspree POST URL handling from the contact form #837

merged 1 commit into from Nov 13, 2020

Conversation

Szasza
Copy link
Contributor

@Szasza Szasza commented Nov 13, 2020

What this PR does / why we need it: It removes the Formspree-specific code parts. These are not needed any more due to Formspree changing its form URLs to random ones.

Which issue this PR fixes:
fixes #723

Special notes for your reviewer: The conversation about this PR was done in #372

Release note:

Consolidating the Formspree-specific POST URL handling to cater for the new random Formspree URLs.

Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. That looks good.

Thanks for the contribution and looking forward to more :P

@stp-ip stp-ip added this to the v0.18.0 milestone Nov 13, 2020
@stp-ip stp-ip merged commit ab258bd into okkur:master Nov 13, 2020
@Szasza
Copy link
Contributor Author

Szasza commented Nov 13, 2020

My pleasure, thank you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Contact form not using async
2 participants