lazy loading and width+height for <img> #2
Conversation
There was a problem hiding this comment.
@midzer thank you for your pull request. Would you mind, unfortunately we couldn't approve your PR directly due to some minor issues. Images with a fixed width and height does not look correct in the viewports XS, SM, MD, LG and XL. These images does not retain the desired optical shape in all viewports in all tested devices. Further more, we cannot change logo width and height in the partner section, because any changes must be discussed in advance with the partners and the arrangement of the logos in the respective viewports. The arrangement in the respective viewports have already been approved. The idea preloading fonts is pretty great. The order of the <head> makes sense and looks good. Using attribute loading="lazy" is pretty straight forward. Best regards
Hi,
been a pleasure to work on this :)
<head>, check https://github.com/rviscomi/capo.js for referenceodd-logo.svgloading="lazy"for all below the fold imagesslightly larger Partner imagesmoved own logo to bottom ("the donkey calls itself at the end")Further possible optimizations regarding page payload:
Cya on monday,
midzer