Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support captions file #31

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Support captions file #31

merged 2 commits into from
Oct 22, 2019

Conversation

oklahomer
Copy link
Owner

@oklahomer oklahomer commented Oct 21, 2019

This change enables developers to upload caption files and fix #30.
d795f36 introduces the function to upload captions file; while 18952ba includes minor refactoring.

@oklahomer oklahomer mentioned this pull request Oct 21, 2019
Copy link

@christophhalbi christophhalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both commits look good!

@oklahomer oklahomer merged commit 34a3636 into master Oct 22, 2019
@oklahomer oklahomer deleted the feature/support_captions_file branch October 22, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload of captions_file
2 participants