dependency on jest-validate breaks tests in create-react-app

[matej-prokop]

If you are using create-react-app and upgrade to link-staged 7.0.0 all your test starts to fail because of TypeError: environment.dispose is not a function

Reason is that lint-staged 7.0.0 started to depend on jest-validate which depends on jest-environment-node and there is clash between different versions of jest-environment-node from CRA and list-staged.

npm ls jest-environment-node

[okonet]

I'm not sure what we should do about it. Probably it's better to report at CRA?

[matej-prokop]

I enjoy using lint-stage so I felt that it is important to inform you that CRA projects are currently forced to stick with lint-staged version 6.x.x.

This sounds more like Jest issue than CRA stuff. Anyway, I understand your point.

[SimenB]

This is a jest issue (jestjs/jest#5294), which has been fixed. CRA uses jest 20 though, which still has the bug (upgraded to 22 in the alpha).

[sudo-suhas]

Shall we close this issue? Do not see any action item for lint-staged.

[gaearon]

I created a new CRA project and ran yarn add lint-staged. I don't see this issue when running yarn test.
What's the full reproducing case?

[stevensacks]

It doesn't happen to me if I npm install lint-staged into an existing project, either. But if I delete package-lock.json and node_modules and then run npm install with lint-staged 7.x in my package.json, that's when it breaks.

[gaearon]

@SimenB This is not jestjs/jest#5294 although it looks similar.

The problem here is because jest-environment-* was also being resolved from the root directory instead of from jest's module directory. I'm not sure if this problem still exists, can you check that please?

[gaearon]

This code seems to still exist in Jest master so a similar problem could manifest itself in the future.

[gaearon]

I filed jestjs/jest#5913.

[gaearon]

I published react-scripts@1.1.3 which should fix environment.dispose is not a function for you.

https://github.com/facebook/create-react-app/releases/tag/v1.1.3

[matej-prokop]

@gaearon Thank you for jumping on this. It is great to have a new version of CRA mitigating this issue. 👍

Now, it is definitely time to close this issue.

[okonet]

Thanks @gaearon for working on it!