Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

448: Correct value for FORCE_COLOR env var #451

Merged
merged 1 commit into from
May 18, 2018

Conversation

plroebuck
Copy link
Contributor

The "support-color" package expects to parse an integer value. Code was wrongly assigning a boolean
when envvars are strings. Don't see how this ever worked. Additionally removed line setting
process.exitCode to its default value (0), and migrated process.exitCode = 1 to top of both catch blocks.

Fixes #448

The "support-color" package expects to parse an integer value. Code was wrongly assigning a boolean
when envvars are strings. Don't see how this ever worked. Additionally removed resetting of
`process.exitCode` to its default value, and migrated `process.exitCode` to top of catch blocks.

Fixes lint-staged#448
@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #451 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   98.71%   98.71%   -0.01%     
==========================================
  Files          12       12              
  Lines         234      233       -1     
  Branches       27       27              
==========================================
- Hits          231      230       -1     
  Misses          3        3
Impacted Files Coverage Δ
src/index.js 91.17% <50%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1601c02...0671081. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented May 18, 2018

Nice! Thanks!

@okonet okonet merged commit 9823d26 into lint-staged:master May 18, 2018
@plroebuck plroebuck mentioned this pull request May 18, 2018
@plroebuck plroebuck deleted the issue/448 branch May 18, 2018 18:51
kornicameister pushed a commit to kornicameister/korni that referenced this pull request May 23, 2018
## Overview

The following dependencies have been updated by [dependencies.io](https://www.dependencies.io/):

- `lint-staged` in `package.json` from "7.0.5" to "7.1.2"

## Details

### `lint-staged`

This dependency is located in `package.json` and was updated from "7.0.5" to "7.1.2".

<details>
<summary>7.1.0</summary>

# [7.1.0](lint-staged/lint-staged@v7.0.5...v7.1.0) (2018-05-07)


### Features

* Chunked execution of linters on Windows only ([#439](lint-staged/lint-staged#439)) ([1601c02](lint-staged/lint-staged@1601c02))

</details>

<details>
<summary>7.1.1</summary>

## [7.1.1](lint-staged/lint-staged@v7.1.0...v7.1.1) (2018-05-18)


### Bug Fixes

* **cli:** Correct value for FORCE_COLOR env var ([#451](lint-staged/lint-staged#451)) ([9823d26](lint-staged/lint-staged@9823d26)), closes [#448](lint-staged/lint-staged#448)

</details>

<details>
<summary>7.1.2</summary>

## [7.1.2](lint-staged/lint-staged@v7.1.1...v7.1.2) (2018-05-21)


### Bug Fixes

* **package:** Update cosmiconfig to version 5.0.2 ([#444](lint-staged/lint-staged#444)) ([2fc7aa3](lint-staged/lint-staged@2fc7aa3)), closes [#441](lint-staged/lint-staged#441)
* **package:** Update listr to version 0.14.1 ([#445](lint-staged/lint-staged#445)) ([a56d7c9](lint-staged/lint-staged@a56d7c9)), closes [#426](lint-staged/lint-staged#426)
* Add .lintstagedrc.js to list of config files to search ([9e27620](lint-staged/lint-staged@9e27620))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants