Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logging for js config errors #935

Merged
merged 3 commits into from
Dec 4, 2020
Merged

better logging for js config errors #935

merged 3 commits into from
Dec 4, 2020

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Dec 4, 2020

Added tests for the original PR #915

kf6kjg and others added 3 commits December 4, 2020 06:08
Before this change javascript config files that had compilation errors or that threw their own errors wouldn't report the error, making debugging a mite more difficult than it should be: instead you'd get a useless "TypeError: Cannot read property 'errors' of undefined" message.  Now if the javascript config file tosses its cookies for whatever reason we can read what that reason was.
@iiroj iiroj requested a review from okonet December 4, 2020 14:12
@iiroj
Copy link
Member Author

iiroj commented Dec 4, 2020

Ping @okonet I added tests based on the original PR #915, so that we can get it merged.

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #935 (4a5dc99) into master (0ff2917) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          609       611    +2     
  Branches       143       144    +1     
=========================================
+ Hits           609       611    +2     
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff2917...4a5dc99. Read the comment docs.

@iiroj iiroj merged commit 292e882 into master Dec 4, 2020
@iiroj iiroj deleted the js-config-errors branch December 4, 2020 15:29
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

🎉 This PR is included in version 10.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants