Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework color palette #481

Closed
loiclaudet opened this issue Sep 25, 2023 · 3 comments
Closed

Rework color palette #481

loiclaudet opened this issue Sep 25, 2023 · 3 comments
Assignees
Labels
enhancement 💯 improving already existing features

Comments

@loiclaudet
Copy link
Contributor

Enhancement/ Color palette

As a developer,
I want to quickly retrieve colors related to the project's design system, using colors palettes.
So that I can easily define colors for new pages or components.

Tech specs

  • implement color palette based on Design System colors, by following guidelines from this discussion.
@loiclaudet loiclaudet self-assigned this Sep 25, 2023
@loiclaudet loiclaudet added the enhancement 💯 improving already existing features label Sep 25, 2023
@loiclaudet
Copy link
Contributor Author

@SpicySalm0n color defined for dataset card text (cf screenshot) doesn't belong to design system colors.

Could you please add it to the design system or provide an alternative color already defined in the design system? Thanks

image

@SpicySalm0n
Copy link

@0xLodz
Hi, yes, it was done before the color system change,
I suggest changing the color to avoid a single addition.
I chose turquoise 200 (#80DADB). Getting too close to the color of the zones, I also suggest modifying the color of the zones with turquoise 700 (#009898) instead of turquoise 500 (#00B6B7) to accentuate the difference. What do you think ?

@loiclaudet
Copy link
Contributor Author

@SpicySalm0n sounds great!

The palette will be updated according to your suggestion.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💯 improving already existing features
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants