Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/various improvements #14

Merged
merged 14 commits into from
Nov 8, 2022
Merged

Refactor/various improvements #14

merged 14 commits into from
Nov 8, 2022

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Nov 7, 2022 •
edited

This PR brings a bunch of improvements to the project, and aims to make this project a canonical project for all our other NextJS projects (waiting for a template).

Changes are:

  • ⚡️ adopt webp format for images in replacement of png. This significally improves the resource load time metric.
      ➜ du -h public/image 
      3.0M    public/image
      ➜ du -h etc/image 
       16M    etc/image
  • 🎨 add the missing property lang to html element.
  • 🎨 add the missing property description to html head element.
  • ♻️ use getServerSideProps for fetching configuration.
  • 🐛 fix hidden menu responding to mouse clicks.
  • 💚 fix the docker build.
  • 💚 add missing dockerignore file.

@ccamel ccamel self-assigned this Nov 7, 2022
@ccamel ccamel force-pushed the refactor/various-improvements branch 2 times, most recently from 3287a66 to b6925ab Compare November 7, 2022 10:09
@ccamel ccamel force-pushed the refactor/various-improvements branch from b6925ab to 6473687 Compare November 7, 2022 10:18
@ccamel
Copy link
Member Author

ccamel commented Nov 7, 2022

FYI @fredericvilcot

@fredericvilcot fredericvilcot mentioned this pull request Nov 7, 2022
Closed
@ccamel ccamel marked this pull request as ready for review November 8, 2022 14:30
fredericvilcot
fredericvilcot approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
First big step to consistency 😎

@ccamel ccamel mentioned this pull request Nov 8, 2022
Merged
@ccamel ccamel merged commit b4b818c into main Nov 8, 2022
@ccamel ccamel deleted the refactor/various-improvements branch November 8, 2022 15:41
@bot-anik
Copy link
Member

bot-anik commented Dec 1, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@ad2ien ad2ien Awaiting requested review from ad2ien

@JoeyDjr JoeyDjr Awaiting requested review from JoeyDjr

Assignees

@ccamel ccamel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccamel @bot-anik @fredericvilcot