Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile recipe for docker test run #1258

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented May 2, 2018

Currently the tests fail with "ValueError: too many values to unpack" due to the settings expecting a database connection string that starts with mysql://. Removing the dialect declaration fixes the errors.

Screenshot of makefile recipe for docker test run failure

c-w added some commits May 2, 2018

Fix makefile recipe for docker test run
Currently the tests fail with "ValueError: too many values to unpack"
due to the settings expecting a database connection string that starts
with `mysql://`. Removing the dialect declaration fixes the errors.
@colinschoen
Copy link
Member

left a comment

LGTM

@colinschoen colinschoen merged commit 2fe0d27 into okpy:master May 2, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the c-w:bug/c-w/fix-docker-tests branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.