Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile recipe for docker test run #1258

Merged
merged 2 commits into from May 2, 2018
Merged

Fix makefile recipe for docker test run #1258

merged 2 commits into from May 2, 2018

Conversation

c-w
Copy link
Contributor

@c-w c-w commented May 2, 2018

Currently the tests fail with "ValueError: too many values to unpack" due to the settings expecting a database connection string that starts with mysql://. Removing the dialect declaration fixes the errors.

Screenshot of makefile recipe for docker test run failure

c-w added 2 commits May 2, 2018 09:20
Currently the tests fail with "ValueError: too many values to unpack"
due to the settings expecting a database connection string that starts
with `mysql://`. Removing the dialect declaration fixes the errors.
Copy link
Member

@colinschoen colinschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschoen colinschoen merged commit 2fe0d27 into okpy:master May 2, 2018
@c-w c-w deleted the bug/c-w/fix-docker-tests branch May 2, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants