Skip to content

Fix makefile recipe for docker test run - #1258

Merged
colinschoen merged 2 commits into
okpy:masterfrom
c-w:bug/c-w/fix-docker-tests
May 2, 2018
Merged

colinschoen merged 2 commits into
okpy:masterfrom
c-w:bug/c-w/fix-docker-tests

Conversation

@c-w

@c-w c-w commented May 2, 2018

Copy link
Copy Markdown
Contributor

Currently the tests fail with "ValueError: too many values to unpack" due to the settings expecting a database connection string that starts with mysql://. Removing the dialect declaration fixes the errors.

Screenshot of makefile recipe for docker test run failure

c-w added 2 commits May 2, 2018 09:20
Currently the tests fail with "ValueError: too many values to unpack"
due to the settings expecting a database connection string that starts
with `mysql://`. Removing the dialect declaration fixes the errors.

@colinschoen colinschoen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschoen
colinschoen merged commit 2fe0d27 into okpy:master May 2, 2018
@c-w
c-w deleted the bug/c-w/fix-docker-tests branch May 2, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants