Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to jobs when hosted at non-root URL #1308

Merged
merged 1 commit into from Jul 3, 2018
Merged

Fix links to jobs when hosted at non-root URL #1308

merged 1 commit into from Jul 3, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 3, 2018

@taupalosaurus found this issue on the jobs page where the links to the job results assumed that the application is always hosted at the root.

This change fixes the links to the job results by pre-pending the APPLICATION_ROOT to the link result URL if it's not already there. Performing this fix in the background job decorator as a post-processing step means that all the existing background job code which uses links as return values doesn't have to change.

Screenshot of issue (blue) and fix (red):

image

Copy link
Member

@colinschoen colinschoen left a comment

LGTM

@colinschoen colinschoen merged commit 199d510 into okpy:master Jul 3, 2018
3 checks passed
@c-w c-w deleted the bug/c-w/non-root-job-links branch Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants