Omit the print of AWS credentials in the console unless verbose option is passed #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxtacu can you review this PR, appreciate that :) |
|
hey @sadok-f You have typo in some places: |
|
Hey @maxtacu , thank you for checking, I've modified my PR. |
sadok-f
changed the title
|
@sadok-f Nice thanks! LGTM. Can you also please just increment the PATCH version and add changes to the CHANGELOG? |
|
p.s. app version is set in |
|
Version incremented and changes added to CHANGELOG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this repo, we're using it as our sso cli tool to access AWS accounts.
we had to modify it a bit to omit the print of the AWS credentials to the console while authenticating.
This MR contains the code change for that, it doesn't change the default behaviour.
Thanks.
Sadok