Respect AWS_SHARED_CREDENTIALS_FILE environment variable when set #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS_SHARED_CREDENTIALS_FILE is a documented AWS CLI environment variable that can be used to specify the location of the credentials file. Support reading the value and configuring internal AwsAuth fields with the value extracted from it. See https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html In this implementation the environment variable takes precedence over the default $HOME/.aws location, which is used as fallback when the environment variable is not present.
|
Thanks for your contribution! Sorry for the delay in review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, while using the CLI I noticed that the path for AWS credentials is hardcoded to
$HOME/.aws/credentials. While this is fine, it does not respectAWS_SHARED_CREDENTIALS_FILEenv var, which may be used to specify the location of such credential file.AWS_SHARED_CREDENTIALS_FILEis a documented AWS CLI environment variable, see https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.htmlThis PR adds support for reading the value and configuring internal
AwsAuthfields with the value extracted from it.In this implementation the environment variable takes precedence over the default
$HOME/.awslocation, which is used as fallback when the environment variable is not present and to my understanding is how the AWS CLI works.Thank you for considering this contribution!