Skip to content

Commit

Permalink
fix: remove irrelevant and confusing items
Browse files Browse the repository at this point in the history
Also add comment for contributors to remove non-applicable items.
  • Loading branch information
benlister-okta committed Dec 11, 2023
1 parent fe7c35a commit 06891c4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/NEW_COMPONENT_PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Thank you for contributing! Please follow the steps below to help us process you

## Component checklist

<!-- Pease track and mark relevant items as part of the component development process -->
<!-- Pease track and mark relevant items as part of the component development process. Remove any non-applicable items. -->

### Code structure

Expand All @@ -39,7 +39,7 @@ Thank you for contributing! Please follow the steps below to help us process you
- [ ] Separate text content from the component's code for translation.
- [ ] Ensure the component renders correctly when language changes.

### Responsive implementation
### Responsive implementation (if applicable)

- [ ] Use CSS media queries to define breakpoints and apply styles.
- [ ] Test fluid layouts and resizing behavior at each breakpoint as needed.
Expand All @@ -59,8 +59,6 @@ Thank you for contributing! Please follow the steps below to help us process you

### Finalize code

- [ ] Review PR for final detailing
- [ ] Approve PR in GitHub
- [ ] Interaction designers, UI eng and visual designers need to review that the Storybook code matches the intended Figma design
- [ ] Interaction designers need to confirm Storybook code matches Supernova
- [ ] Interaction and visual designers merge Figma and code at the same time
Expand Down

0 comments on commit 06891c4

Please sign in to comment.