refactor(odyssey-react): cleanup RadioButton and RadioGroup #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
self-assigned this
jayrajashekariah-okta
approved these changes
Jul 21, 2021
|
|
||
| return ( | ||
| <fieldset className="ods-fieldset" ref={ref} {...omitProps}> | ||
| { legendElement} |
There was a problem hiding this comment.
nit: spacing seems off here
There was a problem hiding this comment.
Thanks @jayrajashekariah-okta I plan to setup prettier as a part of our test runs soon so that some of this is automatically controlled for!
There was a problem hiding this comment.
💯 this is a great idea! I was thinking about this last week as well.
arnoldsandoval
approved these changes
Jul 22, 2021
arnoldsandoval-okta
approved these changes
Jul 22, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our Radio components. We've discussed these changes previously during office hours. A few of the improvements: