Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Angular CLI, ng-packagr #119

Merged

Conversation

denysoblohin-okta
Copy link
Collaborator

@denysoblohin-okta denysoblohin-okta commented Feb 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Currently library is building with custom build script, with help of rollup and patching final package.json

Issue Number: OKTA-567265

What is the new behavior?

  • Migrated to ng-packagr which produces dist in Angular Package Format (APF) as described in official guide to creating libraries. Added angular.json to root with configuration for ng build and ng test (Jest tests, with help of @angular-builders/jest)
  • Library code moved to lib folder, which contains ng-package.json, package.json (without devDependencies and unnecessary scripts) which is used as source for building to dist
  • Test apps are also configured to run Jest tests with ng test (with help of @angular-builders/jest)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@denysoblohin-okta denysoblohin-okta marked this pull request as ready for review February 7, 2023 18:43
Copy link

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Happy to also see the Jest builder changes! 💃🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants