Support Step-up authentication in OktaAuthGuard #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisaduncan
reviewed
Sep 7, 2023
| @@ -100,22 +105,46 @@ export class OktaAuthGuard implements CanActivate, CanActivateChild, CanLoad { | |||
| return this.canActivate(route, state); | |||
| } | |||
|
|
|||
| private async handleLogin(originalUri?: string): Promise<void> { | |||
| private async isAuthenticated(routeData?: Data, authState?: AuthState | null) { | |||
There was a problem hiding this comment.
Should canActivateChild also have this check?
There was a problem hiding this comment.
canActivateChild just calls callActivate: https://github.com/okta/okta-angular/pull/132/files#diff-e5e5f0918a3176e60fa44ce0fe3d25a6311a8ed8f3c4a0113730eb3e0f5e941eR101-R106
There was a problem hiding this comment.
yep, gotcha, just had to actually look better. Thanks!
jaredperreault-okta
approved these changes
Oct 23, 2023
eng-services-aperture-github-bot-okta
deleted the
od-acr-guard-OKTA-597151
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support of Step-up authentication in
OktaAuthGuardby specifyingacrValuesin route data.If current token does not have requested level of assurance, there will be a redirect to
/authorizeendpoint with providedacr_valuesin query parametersMinimum supported version of okta-auth-js for this feature is 7.1.0
Changes for test apps:
acrclaim)Resolves #125
Internal ref: OKTA-597151
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?