[BREAKING] Enable Ivy distribution #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/apps/angular-v11/angular.json
Outdated
| @@ -17,6 +17,9 @@ | |||
| "build": { | |||
| "builder": "@angular-devkit/build-angular:browser", | |||
| "options": { | |||
| "allowedCommonJsDependencies": [ | |||
There was a problem hiding this comment.
To fix warnings like
Warning: @babel/runtime-corejs3/core-js/map depends on 'core-js-pure/features/map'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
There was a problem hiding this comment.
Appreciate the work! Thank you for taking the time to do this POC.
It would be nice if this could be amended to notate that it's not actually a "fix," it merely instructs angular to not emit the warning. The optimization phase can still bail out if there's a conflict in the upstream dep, which will result in an unnecessarily fat build.
A fix would either be transpiling or rewriting the build with ecmascript modules. As a consumer I would appreciate the warning being present until such time as this is the case as it provides ready answer to the inevitable "why is my output so large?" question when the build triggers budget warnings.
re:
https://angular.io/guide/build#configuring-commonjs-dependencies
The Angular CLI outputs warnings if it detects that your browser application depends on CommonJS modules. To disable these warnings, add the CommonJS module name to allowedCommonJsDependencies option in the build options located in angular.json file.
CommonJs impact on optimization:
https://web.dev/commonjs-larger-bundles/
There was a problem hiding this comment.
Done.
Current warnings:
Warning: /node_modules/@okta/okta-auth-js/esm/browser/AuthStateManager.js depends on 'p-cancelable'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Warning: /node_modules/@okta/okta-auth-js/esm/browser/OktaAuth.js depends on 'tiny-emitter'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Warning: /node_modules/@okta/okta-auth-js/esm/browser/fetch/fetchRequest.js depends on 'cross-fetch'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Warning: /node_modules/unload/dist/es/index.js depends on 'detect-node'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies| @@ -24,7 +24,7 @@ | |||
| "typeRoots": [ | |||
| "node_modules/@types/" | |||
| ], | |||
| "types": ["node", "webappsec-credential-management"], | |||
There was a problem hiding this comment.
Not needed if building on Angular 12
src/okta-angular.ts
Outdated
| @@ -14,6 +14,7 @@ export { OktaAuthModule } from './okta/okta.module'; | |||
| export { OktaAuthGuard } from './okta/okta.guard'; | |||
| export { OktaConfig, OKTA_CONFIG, OKTA_AUTH } from './okta/models/okta.config'; | |||
| export { OktaAuthStateService } from './okta/services/auth-state.service'; | |||
| export { OktaHasAnyGroupDirective } from './okta/has-any-group.directive'; | |||
There was a problem hiding this comment.
To fix build on Angular 12:
src/okta/has-any-group.directive.ts:5:14 - error NG3001: Unsupported private class OktaHasAnyGroupDirective. This class is visible to consumers via OktaAuthModule -> OktaHasAnyGroupDirective, but is not exported from the top-level library entrypoint.
5 export class OktaHasAnyGroupDirective {
denysoblohin-okta
force-pushed
the
od-ivy-OKTA-469350
branch
from
455a5e4
to
8627ee9
Compare
denysoblohin-okta
force-pushed
the
od-ivy-OKTA-469350
branch
2 times, most recently
from
f0163a9
to
9a8c284
Compare
denysoblohin-okta
force-pushed
the
od-ivy-OKTA-469350
branch
from
9a8c284
to
262649c
Compare
denysoblohin-okta
changed the title
denysoblohin-okta
requested review from
shuowu,
jaredperreault-okta and
aarongranick-okta
shuowu-okta
approved these changes
Sep 16, 2022
denysoblohin-okta
force-pushed
the
od-ivy-OKTA-469350
branch
from
cd48f7d
to
9f78f94
Compare
shuowu-okta
reviewed
Sep 20, 2022
denysoblohin-okta
force-pushed
the
od-ivy-OKTA-469350
branch
from
5d164f0
to
dec2bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #86
Internal ref: OKTA-530587