Report different user-agent strings for ASP.NET and ASP.NET Core #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertjd
reviewed
Sep 28, 2018
nbarbettini
suggested changes
Oct 8, 2018
| @@ -47,7 +47,7 @@ private static AuthenticationBuilder AddCodeFlow(AuthenticationBuilder builder, | |||
| oidcOptions.GetClaimsFromUserInfoEndpoint = options.GetClaimsFromUserInfoEndpoint; | |||
| oidcOptions.SaveTokens = true; | |||
| oidcOptions.UseTokenLifetime = false; | |||
| oidcOptions.BackchannelHttpHandler = new UserAgentHandler(); | |||
| oidcOptions.BackchannelHttpHandler = new UserAgentHandler("aspnet-core", typeof(OktaAuthenticationOptionsExtensions).Assembly.GetName().Version); | |||
There was a problem hiding this comment.
nit: Use okta-aspnetcore
| @@ -82,7 +82,7 @@ private static void AddJwtBearerAuthentication(IAppBuilder app, OktaWebApiOption | |||
| private static void AddOpenIdConnectAuthentication(IAppBuilder app, OktaMvcOptions options) | |||
| { | |||
| var issuer = UrlHelper.CreateIssuerUrl(options.OktaDomain, options.AuthorizationServerId); | |||
| var httpClient = new HttpClient(new UserAgentHandler()); | |||
| var httpClient = new HttpClient(new UserAgentHandler("aspnet", typeof(OktaMiddlewareExtensions).Assembly.GetName().Version)); | |||
| } | ||
|
|
||
| protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) | ||
| { | ||
| request.Headers.Add("user-agent", UserAgentBuilder.GetUserAgent()); | ||
| request.Headers.Add("user-agent", _userAgentBuilder.GetUserAgent()); |
There was a problem hiding this comment.
Let's use lazy initialization so we only have to call GetUserAgent() once, not on every request. Should be able to just wrap that call in a Lazy<string>.
- Add unit test for UserAgentHandler
nbarbettini
reviewed
Oct 9, 2018
| { | ||
| protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) | ||
| { | ||
| return Task.Factory.StartNew(() => new HttpResponseMessage(HttpStatusCode.OK), cancellationToken); |
There was a problem hiding this comment.
Typically you can use Task.FromResult to return a Task<T>
nbarbettini
approved these changes
Oct 9, 2018
|
LGTM! If you can use |
nbarbettini
reviewed
Oct 11, 2018
| httpRequestMessage.Headers.UserAgent.ToString() | ||
| .IndexOf( | ||
| ProductInfoHeaderValue.Parse($"{frameworkName}/{version.Major}.{version.Minor}.{version.Build}") | ||
| .ToString(), StringComparison.InvariantCultureIgnoreCase).Should().BeGreaterOrEqualTo(0); |
There was a problem hiding this comment.
Just curious, does this work with StringComparison.OrdinalIgnoreCase too, or only InvariantCulture?
There was a problem hiding this comment.
No, it does work with OrdinalIgnoreCase as well.
laura-rodriguez
deleted the
48-report-diff-user-agent-for-aspnet-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48