Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call updateAuthState when handleLoginRedirect fails #1092

Closed
wants to merge 2 commits into from
Closed

Call updateAuthState when handleLoginRedirect fails #1092

wants to merge 2 commits into from

Conversation

denysoblohin-okta
Copy link
Contributor

Fixes issue okta/okta-react#173 in auth-js layer
(Previous PR okta/okta-react#205 with same fix was in okta-react layer)

Issue description: if user visits bad login redirect page (like /login/callback?code=foobar) but has tokens, authState will still be null

Internal ref: OKTA-441939

@denysoblohin-okta denysoblohin-okta mentioned this pull request Feb 3, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #1092 (653be8f) into master (11d6f9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         142      142           
  Lines        3912     3915    +3     
  Branches      815      815           
=======================================
+ Hits         3634     3637    +3     
  Misses        278      278
Impacted Files Coverage Δ
lib/OktaAuth.ts 89.79% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d6f9e...653be8f. Read the comment docs.

shuowu
shuowu approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@shuowu shuowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changelog

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 7, 2022
@eng-prod-CI-bot-okta
Call updateAuthState when handleLoginRedirect fails
e38c90d 
OKTA-441939
<<<Jenkins Check-In of Tested SHA: 7c0c706 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#1092"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@denysoblohin-okta @codecov-commenter @shuowu @eng-prod-CI-bot-okta