Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idx): terminal cancel action issue #1319

Conversation

shuowu-okta
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 92.07% // Head: 92.07% // No change to project coverage 👍

Coverage data is based on head (33c28ac) compared to base (a57a689).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              7.0    #1319   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         214      214           
  Lines        5149     5149           
  Branches     1083     1082    -1     
=======================================
  Hits         4741     4741           
  Misses        385      385           
  Partials       23       23           
Impacted Files Coverage Δ
lib/idx/run.ts 98.31% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glenfannin-okta
Copy link
Contributor

Pulled this branch down locally and tested against SIW v3

auth-js-cancel-fix-video.mov

@glenfannin-okta
Copy link
Contributor

As proof that this fixes the underlying issue, here is a recording of the requests made on the older version of auth-js (as you can see when clicking back to sign in causes an introspect request instead of a cancel request):

Screen.Recording.2022-09-30.at.11.04.58.AM.mov

Copy link
Contributor

@aarongranick-okta aarongranick-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test widget downstream first. Can use dev-7 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants