-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(idx): terminal cancel action issue #1319
fix(idx): terminal cancel action issue #1319
Conversation
Codecov ReportBase: 92.07% // Head: 92.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 7.0 #1319 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 214 214
Lines 5149 5149
Branches 1083 1082 -1
=======================================
Hits 4741 4741
Misses 385 385
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Pulled this branch down locally and tested against SIW v3 auth-js-cancel-fix-video.mov |
As proof that this fixes the underlying issue, here is a recording of the requests made on the older version of auth-js (as you can see when clicking back to sign in causes an introspect request instead of a cancel request): Screen.Recording.2022-09-30.at.11.04.58.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test widget downstream first. Can use dev-7
branch
No description provided.