updates Options type to require issuer #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredperreault-okta
force-pushed
the
jp-issuer-type
branch
from
9c380f3
to
27764ce
Compare
aarongranick-okta
approved these changes
Jan 18, 2024
glenfannin-okta
approved these changes
Jan 19, 2024
| @@ -31,6 +31,7 @@ describe('assertValidConfig', () => { | |||
| it('throw an error if no issuer is passed to the constructor', function () { | |||
| var err; | |||
| try { | |||
| // @ts-expect-error this test is deliberately testing an error is throw if no issuer is passed | |||
There was a problem hiding this comment.
nit
Suggested change
| // @ts-expect-error this test is deliberately testing an error is throw if no issuer is passed | |
| // @ts-expect-error this test is deliberately testing an error is thrown if no issuer is passed |
jaredperreault-okta
force-pushed
the
jp-issuer-type
branch
from
06b0cb3
to
c93d7d8
Compare
glenfannin-okta
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.