Added tokenManager.add/get/remove #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lboyette-okta
force-pushed
the
lb-94714-tokenManager-crud
branch
from
6bab453
to
468a70d
Compare
| var config = require('./config.json'); | ||
| var cookies = require('./cookies'); | ||
|
|
||
| function tokenStorageBuilder(storage) { |
There was a problem hiding this comment.
One thing we might want to think about in the future is extracting this storage logic to another util file so that we can use it for the /authn flow (i.e. to store the stateToken).
There was a problem hiding this comment.
ok. I'll go ahead and do that. The separation makes sense anyway, because we have clientBuilder.js.
|
Looks good to me overall - couple nits, then 🚀 |
lboyette-okta
force-pushed
the
lb-94714-tokenManager-crud
branch
from
468a70d
to
532817e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: OKTA-94714
@rchild-okta
@royalchan-okta
@alexma-okta