fix: signout session already expired scenario #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
swiftone
reviewed
Jul 31, 2020
shuowu-okta
reviewed
Jul 31, 2020
swiftone
reviewed
Jul 31, 2020
aarongranick-okta
force-pushed
the
sw-fix-signout-session-already-expired-scenario
branch
2 times, most recently
from
eba5b29
to
b735953
Compare
shuowu-okta
approved these changes
Aug 7, 2020
aarongranick-okta
force-pushed
the
sw-fix-signout-session-already-expired-scenario
branch
from
7d6de07
to
540ee93
Compare
aarongranick-okta
pushed a commit
that referenced
this pull request
Sep 17, 2020
aarongranick-okta
pushed a commit
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
window.location.originin signOut when users session already expired. This will fix an issue when user already in a secure route (in SPA, like/profile), signOut should redirect user towindow.location.origininstead of reload the/profileroute.(Edit by @aarongranick-okta ): This logic only occurs if
idTokenis missing during signOut. User will be redirected to origin orpostLogoutRedirectUriafter the XHR signOut method is used. If the postLogoutRedirectUri matches the current URI, the page will be reloaded to match the logic of a full redirect.