Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue with oauth params cookie #491

Merged
merged 1 commit into from
Sep 28, 2020
Merged

fixes issue with oauth params cookie #491

merged 1 commit into from
Sep 28, 2020

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Sep 28, 2020 •
edited
Loading

  • maintains compatibility with older widget / authJS versions by reading from cookie before sessionStorage
  • adds E2E tests for siginin widget (problem was reproduced using this test before fix was added)

This PR is for 3.2 branch. Change will be cherry-picked and added to a PR for 4.0 branch

@shuowu
Copy link
Contributor

shuowu commented Sep 28, 2020

Is SIW had been updated with auth-js@4.x? if not, probably the cherry-pick is not needed.

@aarongranick-okta
Copy link
Contributor Author

Is SIW had been updated with auth-js@4.x? if not, probably the cherry-pick is not needed.

SIW has not been updated, but auth-js users may be using 4.x. The 3.x update is mostly for users of react/angular/vue SDKs

@aarongranick-okta aarongranick-okta merged commit e18332d into 3.2 Sep 28, 2020
@aarongranick-okta aarongranick-okta deleted the ag-OKTA-332863-3.2-fix-oauth-params branch September 28, 2020 23:26
aarongranick-okta added a commit that referenced this pull request Sep 28, 2020
@aarongranick-okta
fixes issue with oauth params cookie (#491)
5090da7
aarongranick-okta added a commit that referenced this pull request Sep 28, 2020
@aarongranick-okta
fixes issue with oauth params cookie (#491)
c4c0fd3
aarongranick-okta added a commit that referenced this pull request Sep 29, 2020
@aarongranick-okta
fixes issue with oauth params cookie (#491)
e33876c
aarongranick-okta added a commit that referenced this pull request Oct 7, 2020
@aarongranick-okta
fixes issue with oauth params cookie (#491)
01d781e
aarongranick-okta added a commit that referenced this pull request Oct 20, 2020
@aarongranick-okta
fixes issue with oauth params cookie (#491)
b2d99d6
shuowu-okta pushed a commit that referenced this pull request Oct 20, 2020
@aarongranick-okta @shuowu
fixes issue with oauth params cookie (#491)
3682ed1
shuowu-okta pushed a commit that referenced this pull request Oct 21, 2020
@aarongranick-okta @shuowu
backport fixes from 4.0.2 (#495)
ed400c2 
* fix sameSite cookie settings on HTTP (#489)

* fixes issue with oauth params cookie (#491)

Co-authored-by: Shuo Wu <wushuo2010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aarongranick-okta @shuowu