Check redirect URI in token.isLoginRedirect() #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Check redirect URI in authClient.token.isLoginRedirect() * Added test
aarongranick-okta
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Check redirect URI in authClient.token.isLoginRedirect() * Added test
shuowu-okta
added a commit
that referenced
this pull request
Oct 27, 2020
* Check redirect URI in token.isLoginRedirect() (#520) * Check redirect URI in authClient.token.isLoginRedirect() * Added test * fix: remove types from cherry pick * doc: update changelog Co-authored-by: denysoblohin-okta <72614880+denysoblohin-okta@users.noreply.github.com> Co-authored-by: Shuo Wu <wushuo2010@gmail.com>
|
When is this expected to be added to a release for npm installs? And is there a workaround until it is? |
|
@tcboles - We're working to get an npm release of okta-auth-js 4.1 this week. I'm afraid I don't know of a workaround until then other than building this repo locally for the package. |
aarongranick-okta
pushed a commit
that referenced
this pull request
Oct 29, 2020
* Check redirect URI in authClient.token.isLoginRedirect() * Added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
token.isLoginRedirect()check not only presence of parametercodein query/hash, but current location URI should be allowed redirect URIThus SDK will not false handle any routes with
codeparameter as redirect route.Resolves: #474
Internal ref: https://oktainc.atlassian.net/browse/OKTA-331632