Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useInteractionCodeFlow option to samples, upgrade test app #565

Closed
wants to merge 1 commit into from

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Dec 16, 2020

Adds option useInteractionCodeFlow to samples that use the widget.

Upgrades test app:

  • support any widget version
  • control whether the widget redirects or receives tokens directly
  • support interaction code flow
  • support authorization code flow

Splits SIW E2E tests into redirect and non-redirect variants

@@ -1,3 +1,4 @@
<!DOCTYPE html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #565 (b958410) into master (236a4a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files          41       41           
  Lines        2349     2349           
  Branches      513      513           
=======================================
  Hits         2159     2159           
  Misses        190      190           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236a4a4...b958410. Read the comment docs.

- test app adds support for authorization code flow

- test app adds forceRedirect option
- test app supports older widgets

- split SIW login E2E test into redirect / no redirect versions
@aarongranick-okta aarongranick-okta changed the title Add useInteractionCodeFlow option to samples Add useInteractionCodeFlow option to samples, upgrade test app Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants