Update header levels in Activate Factor section #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nbarbettini This is actually going to be a thing for ALL pages. do we want to do a new PR to fix all others (ie. search and replace for these?) or add to this PR? |
nbarbettini
approved these changes
May 9, 2019
|
@bretterer Good catch. Let's get this merged and create a follow up task. @joshreesjones-okta Thanks for your continued contribs! |
|
Follow up task: #328 |
|
Built locally and confirmed it looks how it should:
👍 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On the Factors page, the Activate Factors section (https://developer.okta.com/docs/api/resources/factors/#activate-factor) has a lot of "Request Parameters", "Response Parameters", "Request Example", and "Response Example" headers in the table of contents:
I'm guessing we don't want those there (correct me if I'm wrong, though). I updated the header levels so that it seemed more like what we'd want to see.
I did not verify what the table of contents looks like after these changes because I couldn't build locally. I am assuming that the table of contents is generated from the header structure in the Markdown file, but if not, let me know and I'll update whatever I need to.
Resolves:
N/A
@bretterer