Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

spomky-labs/jose is deprecated. Update the documentation to use the… #29

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

rlbaxter
Copy link
Contributor

…firebase library as the primary example

@codecov-io
Copy link

Codecov Report

Merging #29 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #29   +/-   ##
==========================================
  Coverage      27.39%   27.39%           
  Complexity        91       91           
==========================================
  Files             10       10           
  Lines            219      219           
==========================================
  Hits              60       60           
  Misses           159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cef606...7d419fe. Read the comment docs.

@bretterer
Copy link
Collaborator

@rlbaxter thank you for this PR, have you made sure that this still works with firebase? Could you also include a removal of the dependency for spomky-labs from the composer.json file?

@alexwilson
Copy link
Contributor

@bretterer Can confirm that this works with Firebase like a charm! 👍

@bretterer bretterer merged commit 3fced3e into okta:develop Dec 11, 2019
@bretterer
Copy link
Collaborator

Thank you for your PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants