Implement session token exchange flow #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayNewstrom
approved these changes
Jun 30, 2022
| import AuthFoundation | ||
|
|
||
| /// An authentication flow class that exchanges a Session Token for access tokens. | ||
| public class SessionTokenFlow: AuthenticationFlow { |
There was a problem hiding this comment.
I haven't looked closely at many of these, but should this be final? I think final is a good default for classes, and it should be explicitly designed to be extended if it's not marked final.
There was a problem hiding this comment.
I haven't been marking the classes as final since some of them required subclassing to override behaviours in tests. You bring up a good point though, since after auditing my code, it doesn't appear I need to do that anymore.
jaynewstrom-okta
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.