Update device authorization and JWKS to closer match the spec #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayNewstrom
reviewed
Jul 6, 2022
|
Yeah, that seems like the right thing to do. Also, Okta has a feature for defining a default scope for when a client doesn't supply one, so we might want to make the |
JayNewstrom
reviewed
Jul 6, 2022
| let data = data(for: """ | ||
| { | ||
| "token_type": "Bearer", | ||
| "expires_in": 3600, |
There was a problem hiding this comment.
Worth noting, some Authorization servers may not return expires_in (notably when you are doing pure OAuth, without OIDC). I don't think it's something we need to account for, but I think the only 2 things that are required from OAuth are access_token/token_type.
There was a problem hiding this comment.
Yeah, I'm not sure if we should worry about that. There's a lot of code that assumes the expires_in exists, for both Swift and Kotlin SDKs. So I'd hold off on this, until it's necessary.
jaynewstrom-okta
approved these changes
Jul 6, 2022
mikenachbaur-okta
force-pushed
the
man-OKTA-512299-UpdateSpec
branch
from
0de74dc
to
8fc02bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches up to okta/okta-mobile-kotlin#183 and okta/okta-mobile-kotlin#182