OKTA-295706 add usertypes #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| updatedUserType.Description.Should().Be(updatedDescription); | ||
| updatedUserType.DisplayName.Should().Be(updatedDisplayName); | ||
|
|
||
| var retrievedForValidation = await testClient.UserTypes.GetUserTypeAsync(createdUserType.Id); |
There was a problem hiding this comment.
nit: I suggest using more descriptive names. I would rename this to retrievedUserTypeForValidation, so we know it is a user type.
| replacedUserType.DisplayName.Should().Be(replacedDisplayName); | ||
| replacedUserType.Name.Should().Be(testName); | ||
|
|
||
| var retrievedForValidation = await testClient.UserTypes.GetUserTypeAsync(createdUserType.Id); |
There was a problem hiding this comment.
nit: descriptive names. See above.
|
|
||
| try | ||
| { | ||
| HashSet<string> allUserTypeIds = new HashSet<string>(); |
There was a problem hiding this comment.
nit: In this method we have vars and explicitly typed vars, let's try to use the same coding rules when it's possible for consistency. In general, this SDK is using vars, so I would stick to it.
laura-rodriguez
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
OKTA-295706
Code