Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKTA-285615 add inlinehooks integration tests #380

Merged
merged 3 commits into from May 21, 2020

Conversation

bryanapellanes-okta
Copy link
Contributor

Issue #

OKTA-285615

Code

  • Integration tests

Copy link
Collaborator

@laura-rodriguez laura-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few comments.

Copy link
Collaborator

@laura-rodriguez laura-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Same comment about unique names here. Thanks!

@bryanapellanes-okta bryanapellanes-okta merged commit 5d589f4 into dev May 21, 2020
@bryanapellanes-okta bryanapellanes-okta deleted the OKTA-285615-add-inlinehooks branch May 21, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants