OKTA-300462 account for user race condition #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanapellanes-okta
force-pushed
the
OKTA-300462-account-for-user-race-condition
branch
3 times, most recently
from
8ec087f
to
ed53c21
Compare
bryanapellanes-okta
force-pushed
the
OKTA-300462-account-for-user-race-condition
branch
from
ed53c21
to
4515991
Compare
bryanapellanes-okta
force-pushed
the
OKTA-300462-account-for-user-race-condition
branch
from
4515991
to
4fe6676
Compare
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| namespace Okta.Sdk.IntegrationTests | |||
| { | |||
| public class EventHooksClientShould | |||
| public class EventHooksClientScenarios | |||
There was a problem hiding this comment.
Make sure to update the header as well.
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| namespace Okta.Sdk.IntegrationTests | |||
| { | |||
| public class InlineHooksClientShould | |||
| public class InlineHooksClientScenarios | |||
There was a problem hiding this comment.
Make sure to update the header as well.
| using System.Threading.Tasks; | ||
| using FluentAssertions; | ||
| using Xunit; | ||
|
|
||
| namespace Okta.Sdk.IntegrationTests | ||
| { | ||
| public class UserTypesClientShould | ||
| public class UserTypesClientScenarios |
There was a problem hiding this comment.
Make sure to update the header as well.
laura-rodriguez
approved these changes
Jun 11, 2020
bryanapellanes-okta
deleted the
OKTA-300462-account-for-user-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for eventual consistency
The primary change introduced here are Thread.Sleep additions on creation of new data. Was seeing intermittent 404 responses when new data entries are made, likely due to GET requests going to read only data replicas. This change waits a few seconds to allow for data replication prior to read attempts.