OKTA-285607: add authorization servers integration tests #388
Conversation
bryanapellanes-okta
force-pushed
the
OKTA-285607-authorization-servers
branch
from
8def64d
to
de0b8ec
Compare
bryanapellanes-okta
force-pushed
the
OKTA-285607-authorization-servers
branch
from
78de594
to
a5ba442
Compare
|
@laura-rodriguez I updated to use aliases. I ran all the tests locally against my own org and everything passed. |
| }; | ||
|
|
||
| var createdAuthorizationServer = await testClient.AuthorizationServers.CreateAuthorizationServerAsync(testAuthorizationServer); | ||
| var createdPolicy = await testClient.AuthorizationServers.CreateAuthorizationServerPolicyAsync(testPolicy, createdAuthorizationServer.Id); |
There was a problem hiding this comment.
Do we have an alias for CreateAuthorizationServerPolicyAsync?
| var createdPolicy = await testClient.AuthorizationServers.CreateAuthorizationServerPolicyAsync(testPolicy, createdAuthorizationServer.Id); | ||
| try | ||
| { | ||
| var policies = await testClient.AuthorizationServers.ListAuthorizationServerPolicies(createdAuthorizationServer.Id).ToListAsync(); |
There was a problem hiding this comment.
Do we have an alias for ListAuthorizationServerPolicies?
| createdAuthorizationServer.Should().NotBeNull(); | ||
| createdPolicy.Should().NotBeNull(); | ||
|
|
||
| var retrievedPolicy = await testClient.AuthorizationServers.GetAuthorizationServerPolicyAsync(createdAuthorizationServer.Id, createdPolicy.Id); |
There was a problem hiding this comment.
Do we have an alias for GetAuthorizationServerPolicyAsync?
| var testPolicy = new OAuthAuthorizationPolicy | ||
| { | ||
| Name = $"{SdkPrefix}:Test Policy", | ||
| Type = PolicyType.OauthAuthorizationPolicy, |
There was a problem hiding this comment.
We should rename OauthAuthorizationPolicy to OAuthAuthorizationPolicy to be consistent with the policy name.
There was a problem hiding this comment.
That is a pre-existing type from a couple years ago. Wasn't sure if changing it would cause issues if it is already referenced outside of what we can see.
There was a problem hiding this comment.
We have renamed other stuff as well keeping in mind that all SDKs will release a major version.
| { | ||
| updatedPolicy.Should().NotBeNull(); | ||
| updatedPolicy.Name.Should().Be($"{SdkPrefix}:Test Policy Updated"); | ||
| updatedPolicy.Description.Should().Be( "Test policy description updated"); |
There was a problem hiding this comment.
nit: Fix space after parentheses.
| var createdOAuthScope = await createdAuthorizationServer.CreateOAuth2ScopeAsync(testOAuthScope); | ||
| try | ||
| { | ||
| var allAuthorizationServerScopes = await testClient.AuthorizationServers.ListOAuth2Scopes(createdAuthorizationServer.Id).ToListAsync(); |
There was a problem hiding this comment.
Do we have an alias for ListOAuth2Scopes?
| createdAuthorizationServer.Should().NotBeNull(); | ||
| createdOAuthClaim.Should().NotBeNull(); | ||
| createdOAuthClaim.Name.Should().Be(testOAuthClaim.Name); | ||
| var updatedOAuthScope = await testClient.AuthorizationServers.UpdateOAuth2ClaimAsync(testUpdatedOAuthClaim, createdAuthorizationServer.Id, createdOAuthClaim.Id); |
There was a problem hiding this comment.
DO we have an alias for UpdateOAuth2ClaimAsync?
Issue #
OKTA-285607
Code