Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskip tests that should pass now #405

Merged
merged 1 commit into from Jul 7, 2020
Merged

unskip tests that should pass now #405

merged 1 commit into from Jul 7, 2020

Conversation

bryanapellanes-okta
Copy link
Contributor

Additional Context

Un-skipped tests that should now pass.

@bryanapellanes-okta bryanapellanes-okta marked this pull request as ready for review July 7, 2020 16:23
Copy link
Collaborator

@laura-rodriguez laura-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and Travis is green ❤️ ! I think we have more keys related ITs in application scenarios (maybe users too?) that we can unskip now. Can you please double-check them too?

@bryanapellanes-okta bryanapellanes-okta merged commit b2a6d1f into dev Jul 7, 2020
@bryanapellanes-okta bryanapellanes-okta deleted the unskip-tests branch July 7, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants