Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid hitting rate limits by looking at X-Rate-Limit-* headers #434

Open
erezrokah opened this issue Feb 28, 2024 · 26 comments
Open
Labels
enhancement New feature or request

Comments

@erezrokah
Copy link

Describe the feature request?

Implement the best practices from https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit to avoid hitting rate limits, and also wait until the limit reset time instead of a retry/backoff mechanism.

New or Affected Resource(s)

All existing and new resources will be affected I think

Provide a documentation link

https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit

Additional Information?

I'm aware of the existing backoff and retry configuration, it seems better practice to follow the headers returned from the server

@erezrokah erezrokah added the enhancement New feature or request label Feb 28, 2024
@tjpoe
Copy link

tjpoe commented Feb 28, 2024

agreed. we are hitting rate warnings on our instance and would love a way to throttle the speed of requests to stay within the api limitation.

Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Mar 14, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Mar 15, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Mar 30, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Mar 31, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Apr 14, 2024
@erezrokah
Copy link
Author

Not stale

@erezrokah
Copy link
Author

Proposal at #450, will wait for feedback before adding docs, tests and updating the template files that generate the code

Copy link

github-actions bot commented May 2, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label May 2, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label May 3, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label May 18, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label May 19, 2024
Copy link

github-actions bot commented Jun 2, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Jun 2, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Jun 3, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Jun 17, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Jun 18, 2024
Copy link

github-actions bot commented Jul 2, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Jul 2, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Jul 3, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Jul 17, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Jul 18, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Aug 1, 2024
@erezrokah
Copy link
Author

Not stale, will try to respond to #450 soon

@github-actions github-actions bot removed the stale label Aug 2, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Aug 16, 2024
@erezrokah
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale label Aug 17, 2024
Copy link

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Aug 31, 2024
@erezrokah
Copy link
Author

Not stale

@erezrokah erezrokah reopened this Sep 3, 2024
@github-actions github-actions bot removed the stale label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants