fix empty nonce for dpop #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com>
duytiennguyen-okta
force-pushed
the
fix-empty-nonce-for-dpop
branch
from
9e108e0
to
610231f
Compare
monde
approved these changes
Jun 3, 2024
az-zemr
reviewed
Jun 4, 2024
| @@ -161,13 +161,13 @@ func NewPrivateKeyAuth(config PrivateKeyAuthConfig) *PrivateKeyAuth { | |||
|
|
|||
| func (a *PrivateKeyAuth) Authorize(method, URL string) error { | |||
| accessToken, hasToken := a.tokenCache.Get(AccessTokenCacheKey) | |||
| if hasToken { | |||
| if hasToken && accessToken != "" { | |||
There was a problem hiding this comment.
it seems like hasToken/ok checks are excessive with such approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type of PR
Test Information
Go Version:
Os Version:
OpenAPI Spec Version:
Signoff
make fmton my codeClose #461
Close #462