Fixes issue with iOS Safari and autofill (#101)

No longer re-renders primary auth form on changes to the rememberMe checkbox,
which caused iOS Safari autofill to repopulate the username and prevent the
user from changing their username.

RESOLVES OKTA-98946

src/views/primary-auth/PrimaryAuthForm.js

@@ -97,7 +97,14 @@ define([
           'label-top': true,
           className: 'margin-btm-0',
           initialize: function () {
-            this.listenTo(this.model, 'change:username', this.render);
+            this.listenTo(this.model, 'change:remember', function (model, val) {
+              // OKTA-98946: We normally re-render on changes to model values,
+              // but in this case we will manually update the checkbox due to
+              // iOS Safari and how it handles autofill - it will autofill the
+              // form anytime the dom elements are re-rendered, which prevents
+              // the user from editing their username.
+              this.$(':checkbox').prop('checked', val).trigger('updateState');
+            });
           }
         });
       }

test/spec/PrimaryAuth_spec.js

@@ -904,6 +904,17 @@ function (_, $, Q, OktaAuth, LoginUtil, Okta, Util, PrimaryAuthForm, Beacon,
           expect(test.form.rememberMeCheckboxStatus()).toBe('unchecked');
         });
       });
+      itp('does not re-render rememberMe checkbox on changes', function () {
+        Util.mockCookie('ln', 'testuser');
+        var options = {
+          'features.rememberMe': true
+        };
+        return setup(options).then(function (test) {
+          var orig = test.form.rememberMeCheckbox().get(0);
+          test.form.setUsername('new-user');
+          expect(test.form.rememberMeCheckbox().get(0)).toBe(orig);
+        });
+      });
       itp('populate username if username is available', function () {
         var options = {
           'username': 'testuser@ABC.com'