Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Changed border color on focused button #178

Merged
merged 2 commits into from Mar 1, 2017

Conversation

eugenebakaiev-okta
Copy link
Contributor

Added variable for focused input color
Resolves: OKTA-117073

@eugenebakaiev-okta
Copy link
Contributor Author

buttonfocus mov

@eugenebakaiev-okta
Copy link
Contributor Author

@hor-kanchan-okta please take a look

@eugenebakaiev-okta
Copy link
Contributor Author

@mauriciocastillosilva-okta, could you please take a look?

Copy link
Contributor

@hor-kanchan-okta hor-kanchan-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hor-kanchan-okta hor-kanchan-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one thing:

  • Can you check _btns.scss to double check nothing there will affect/override your change?

@mauriciocastillosilva-okta
Copy link
Contributor

Also, please change the commit message to present tense (https://github.com/alanzhou-okta/conventional-github-releaser-okta/blob/master/CONTRIBUTING.md)

Add variable for focused input color
Resolves: OKTA-117073
@eugenebakaiev-okta
Copy link
Contributor Author

@mauriciocastillosilva-okta checked, it's okay, there's no impacts on my fix in _btns.scss.

@hor-kanchan-okta hor-kanchan-okta merged commit 3002f7d into okta:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants