New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Changed border color on focused button #178
🐛 Changed border color on focused button #178
Conversation
@hor-kanchan-okta please take a look |
@mauriciocastillosilva-okta, could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but one thing:
- Can you check _btns.scss to double check nothing there will affect/override your change?
Also, please change the commit message to present tense (https://github.com/alanzhou-okta/conventional-github-releaser-okta/blob/master/CONTRIBUTING.md) |
3f8d211
to
d98da7f
Compare
Add variable for focused input color Resolves: OKTA-117073
d98da7f
to
594fc75
Compare
@mauriciocastillosilva-okta checked, it's okay, there's no impacts on my fix in _btns.scss. |
Added variable for focused input color
Resolves: OKTA-117073