🐛 set the correct default factor for recovery flows #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forgot Password and Unlock Account flows were defaulting to email for the recovery factor. If a user press 'Enter' in the for, we were sending a request with email as a factor, even if email was not on the available factors (features.emailRecovery=false). - The fix is to default to the factor that is first on the list Resolves: OKTA-141184
mauriciocastillosilva-okta
requested review from
rchild-okta and
gowthamidommety-okta
rchild-okta
approved these changes
Sep 21, 2017
| } | ||
| if (emailEnabled) { | ||
| this.$el.addClass('forgot-password-email-enabled'); | ||
| formChildren.push(this.createRecoveryFactorButton('email-button', 'password.forgot.sendEmail', | ||
| Enums.RECOVERY_FACTOR_TYPE_EMAIL, this)); | ||
| this.setDefaultFactorType(Enums.RECOVERY_FACTOR_TYPE_EMAIL); |
There was a problem hiding this comment.
Double checking - is this the right order of preference (SMS, then call, then email)?
Edit: Looking at the test cases, this is indeed the intended behavior. Good!
mauriciocastillosilva-okta
deleted the
mcs-okta-141184-defaultRecoveryFactorIssue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: OKTA-141184