Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make IdP Discovery redirect automatic #672

Conversation

manueltanzi-okta
Copy link
Contributor

@manueltanzi-okta manueltanzi-okta commented Apr 8, 2019

Description

Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback.

(Feel free to suggest README improvements)

Jira: https://oktainc.atlassian.net/browse/OKTA-212312

Reviewers

@haishengwu-okta @royalchan-okta @nbarbettini

Additional Reviewers

@antonshyltsev-okta

Copy link
Contributor

@haishengwu-okta haishengwu-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • could you make notes (or jira) to remind ourselves to remove idp_discovery logic from main-loginpage ?

@manueltanzi-okta
Copy link
Contributor Author

@manueltanzi-okta manueltanzi-okta force-pushed the manueltanzi-idp-discovery-automatic-redirect branch from 871a1c8 to b06046b Compare April 8, 2019 22:52
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
@manueltanzi-okta manueltanzi-okta force-pushed the manueltanzi-idp-discovery-automatic-redirect branch from b06046b to 6a0c090 Compare April 9, 2019 21:18
@manueltanzi-okta manueltanzi-okta merged commit 868cd53 into okta:dev-3.0 Apr 9, 2019
manueltanzi-okta added a commit that referenced this pull request Apr 19, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Apr 22, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Apr 25, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 2, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 6, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 24, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 28, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 29, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request May 29, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Jun 4, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Jun 28, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Jul 3, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
manueltanzi-okta added a commit that referenced this pull request Jul 3, 2019
Make IdP Discovery redirect automatic rather than requiring to call res.idpDiscover.redirectToIdp() in the success callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants