Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The okta_groups data source has a hard cap of 300 groups returned #944

Closed
jyoder-deloitte opened this issue Feb 3, 2022 · 5 comments
Closed
Assignees
Labels

Comments

@jyoder-deloitte
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v1.0.8
on darwin_amd64

provider registry.terraform.io/hashicorp/aws v3.74.0
provider registry.terraform.io/okta/okta v3.20.5

Affected Resource(s)

  • data.okta_groups

Terraform Configuration Files

data "okta_groups" "apps" {
  q    = "app-"
  type = "OKTA_GROUP"
}

output "app_group_count" {
  description = "Okta App Group Count"
  value = length(data.okta_groups.apps.groups)
}

Expected Behavior

A full list of all matching groups should be returned in the data.okta_group.apps.groups list

Actual Behavior

Only the first 300 matching groups are returned in the data.okta_group.apps.groups list

Steps to Reproduce

  1. terraform plan
  2. Examine the app_group_count output value

Important Factoids

Thank you for the prompt fix to #932! Unfortunately the fix only got me another 100 groups. I still have at least 115 more to go.

References

@monde
Copy link
Collaborator

monde commented Feb 3, 2022

Thanks @jyoder-deloitte. I can see what is causing this. The provider is making a query to the find groups API endpoint via the okta-sdk-golang package and API's default max results returned is 300 on the find query. We can fix this in a PR.

@jyoder-deloitte
Copy link
Author

jyoder-deloitte commented Feb 7, 2022

@monde @MikeMondragon-okta @bogdanprodan-okta Thanks for promptly fixing this, but it looks like it just missed the v3.20.6 release. Can you create a v3.20.7?

@monde
Copy link
Collaborator

monde commented Feb 7, 2022

@jyoder-deloitte I'll cut a v3.20.7 release in the next hour and report back here.

@monde
Copy link
Collaborator

monde commented Feb 7, 2022

@jyoder-deloitte I'm double checking some additional items in the provider before my original estimate of a quick release. However, this release will be going out at some time today.

@monde
Copy link
Collaborator

monde commented Feb 8, 2022

virgofx pushed a commit to virgofx/terraform-provider-okta that referenced this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants