Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to okta_email_customization, okta_org_configuration, #1322

Merged
merged 23 commits into from
Oct 4, 2022
Merged

Updates to okta_email_customization, okta_org_configuration, #1322

merged 23 commits into from
Oct 4, 2022

Conversation

monde
Copy link
Collaborator

@monde monde commented Oct 4, 2022

  • Fixed (unreported) bug where resource okta_org_configuration would null out org settings
  • Fixed an ACC test with resource okta_user_schema_property that would cause a incorrect login flow blocking out the admin
  • Fixed/improved sms template tests
  • Marked the schema enum boolean tests skip as there is an issue with the public API / monolith
  • Improved resource okta_email_customization behavior with regards to the is_default property
  • Cleaned up code paths for default/system policy getting/setting for apps and policies
  • Added explicit errors with error messages that refer online documentation for OIE-only resources when the provider is run against a Classic org
    • datasource okta_app_signon_policy
    • datasource okta_authenticator
    • resource okta_app_signon_policy
    • resource okta_authenticator
    • resource okta_captcha
    • resource okta_captcha_org_wide_settings
    • resource okta_policy_profile_enrollment
    • resource okta_policy_profile_enrollment_apps
    • resource okta_policy_rule_profile_enrollment
  • Fixed and/or cleaned up a number of other ACC tests

@monde
names/labels for resource need to start with testAcc_ so they get
ddd59b1 
properly swept.
@monde
ACCESS_POLICY type sweeper
73346c0
@monde
CRUD ops on datasources/resources that are OIE only will error out.
5e42d96
@monde
Clean up default/system policy getting/setting.
374152c
@monde
Use a runtime assigned hostname variable so TestAccOktaResourceSet …
59c9b5a 
…passes on all test orgs.
@monde
Improve resource okta_email_customization behavior and update tests…
f4e4b36 
… and documentation for this resource.
@monde
Clean up the test skip filter for specfic errors.
af6e6dc
@monde
Skipping TestAccResourceOktaGroupSchema_array_enum_boolean as there i…
ef0ecbe 
…s a monolith bug related to it.
@monde
Skipping TestAccResourceOktaGroupSchema_enum_boolean as there is a mo…
b52d45f 
…nolith bug related to it.
@monde
Ensure company name is unique to prevent flapping tests.
4eb12b1
@monde
Clean up TestAccDataSourceOktaEmailCustomization_read to pass.
7a75ad1
@monde
Clean up TestAccDataSourceOktaEmailCustomizations_read to pass.
d2afd08
@monde
Clean up TestAccDataSourceOktaEmailTemplates_read to pass. Depending on
256650a 
org creation and updates not every org will have the same number of
email templates.
@monde
Fix TestAccAppSaml_userGroups test.
3c36a78
@monde
Skipping TestAccResourceOktaUserSchema_array_enum_boolean and
1054722 
`TestAccResourceOktaUserSchema_enum_boolean` as there is a monolith bug
related to booleans.
@monde
Corrected typo'd captcha file names.
90a7502
@monde
Corrected and expanded TestAccOktaSmsTemplate_crud test.
bf0edb1
@monde
Fix unreported bug with org settings updates nulling out unmanaged
9fe9bfe 
values. Correct test setup and teardown to restore the org's original
name.
@monde
Working why running the okta_user_schema_property ACC tests could
d557a81 
block login when a custom property is set to true.
@monde monde merged commit 287cc9c into master Oct 4, 2022
@monde monde deleted the issue_1311_okta_app_signon_policy branch October 4, 2022 22:31
@monde monde mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijetmahabaleshwar-okta vijetmahabaleshwar-okta vijetmahabaleshwar-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monde @vijetmahabaleshwar-okta