Support Okta Managed certificates #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @virgofx! Really appreciate the PR. Could you also add the new field to the corresponding documentation? |
|
Whups, missed that. Should be good now. |
virgofx
force-pushed
the
mark/support-okta-managed-certs
branch
from
679709a
to
ec44a4a
Compare
virgofx
force-pushed
the
mark/support-okta-managed-certs
branch
from
ec44a4a
to
03528ca
Compare
virgofx
force-pushed
the
mark/support-okta-managed-certs
branch
from
03528ca
to
d851a99
Compare
bogdanprodan-okta
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882
Confirmed locally testing creation of new
OKTA_MANAGEDcert and getting the resource to create/manage it. The READ wasn't necessary as originally suspected it was since I guess we still won't import but handle it first time on create which works properly handling the other success caseCOMPLETED.Backwards compatible with the addition of the
certificate_source_typeparameter by using existing default value ofMANUALand setting as optional. Ideally, it might make sense to change this to required on next version bump and remove theMANUALas default as it's really an explicit user choice (and this mirrors the Okta API). If that were a preference for next version, I could quickly update./cc @bogdanprodan-okta