Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools Update #912

Merged
merged 8 commits into from Feb 1, 2022
Merged

Tools Update #912

merged 8 commits into from Feb 1, 2022

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Jan 16, 2022

PR:

  • Updates gofumpt to 0.2.1
  • Corrects install method for tfproviderlint and pins to current latest version
  • Removes golint-ci due to its deprecation
  • Adds staticcheck and includes in vet commands
  • Simplifies the formatting for go vet since we no longer have the vendored files
  • Tweaks/corrections to the commands in the GNUmakefile

@ymylei ymylei marked this pull request as ready for review January 16, 2022 04:24
@virgofx
Copy link
Contributor

virgofx commented Jan 27, 2022

Looks good, thanks @ymylei

@monde monde self-requested a review February 1, 2022 22:02
monde
monde approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up.

@monde monde merged commit e5c61b2 into okta:master Feb 1, 2022
@ymylei ymylei deleted the tool-update branch February 2, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monde monde monde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ymylei @virgofx @monde