Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Mutex Fix For apps/{id} endpoint #933

Merged
merged 5 commits into from Feb 2, 2022
Merged

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Jan 30, 2022

This corrects the behavior of the API mutex to ensure that all the per app operations are correctly being allocated to the RL bucket for the individual app endpoint (per #913), instead of being allocated to the top level bucket.

Test Results:

➜  terraform-provider-okta git:(rl-bucket-fix) make test
go mod tidy
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
go test: -i flag is deprecated
echo $(go list ./... |grep -v 'vendor') | \
                xargs -t -n4 go test   -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 github.com/okta/terraform-provider-okta github.com/okta/terraform-provider-okta/okta github.com/okta/terraform-provider-okta/okta/internal/apimutex github.com/okta/terraform-provider-okta/okta/internal/transport
?       github.com/okta/terraform-provider-okta [no test files]
ok      github.com/okta/terraform-provider-okta/okta    (cached)
ok      github.com/okta/terraform-provider-okta/okta/internal/apimutex  4.057s
ok      github.com/okta/terraform-provider-okta/okta/internal/transport (cached)
go test -timeout=30s -parallel=4 github.com/okta/terraform-provider-okta/sdk
?       github.com/okta/terraform-provider-okta/sdk     [no test files]

@ymylei ymylei changed the title API Mutex Fix For apps/{id} endpoint stuff API Mutex Fix For apps/{id} endpoint Jan 30, 2022
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @ymylei

@monde monde merged commit 22f82cf into okta:master Feb 2, 2022
@ymylei ymylei deleted the rl-bucket-fix branch February 3, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants