Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure okta_authenticator settings are ordered to prevent whitespace … #936

Merged
merged 1 commit into from Feb 1, 2022
Merged

Ensure okta_authenticator settings are ordered to prevent whitespace … #936

merged 1 commit into from Feb 1, 2022

Conversation

virgofx
Copy link
Contributor

@virgofx virgofx commented Feb 1, 2022 •
edited

Added a unmarshall to marshall on the string (similar to the normalize function that operates on interface) to help normalize the JSON that's stored into state.

Fixes #881

Tested locally on same resource erroring in #881 and 👍

okta_authenticator.okta_verify: Refreshing state... [id=autahjkfkpX25b8WU696]
2022-01-31T18:33:20.583-0800 [INFO]  provider.terraform-provider-okta_v3.20.2.exe: 2022/01/31 18:33:20 [{"channelBinding":{"required":"NEVER","style":"NUMBER_CHALLENGE"},"compliance":{"fips":"OPTIONAL"},"userVerification":"PREFERRED"}]: timestamp=2022-01-31T18:33:20.583-0800

No changes. Your infrastructure matches the configuration.

@monde
Copy link
Collaborator

monde commented Feb 1, 2022

Thanks for the PR @virgofx , I'll check it out when I'm at work tomorrow

monde
monde approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this extra bit of normalization to address #881

@monde monde merged commit becb4cb into okta:master Feb 1, 2022
@virgofx virgofx deleted the okta/fix-authenticator-whitespace-diff branch February 1, 2022 22:31
@monde monde mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monde monde monde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

okta_authenticator settings doesn't diff whitespace changes
2 participants
@virgofx @monde