WIP: Add support for environment feature #16
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "JHipster Starter", | |||
| "baseref": "504dfeec2df39683cdb1500d34853582ca9b8df7", | |||
| "baseref": "master", | |||
There was a problem hiding this comment.
Not sure about this change
There was a problem hiding this comment.
This is a risky change and probably not something we want to do. It'll pin the versions that are used in the starter to the latest ones on the master branch of the Ionic Team's starter project. It's better to pin things to a specific commit so you know what versions of libraries to expect.
There was a problem hiding this comment.
Sure.
I checked the commits on the ionic-team starter project and it's mostly bumping versions so maybe I can update baseref to the latest commit.
It will also remove some security vulnerabilities in package.json dependencies
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "JHipster Starter", | |||
| "baseref": "504dfeec2df39683cdb1500d34853582ca9b8df7", | |||
| "baseref": "master", | |||
There was a problem hiding this comment.
This is a risky change and probably not something we want to do. It'll pin the versions that are used in the starter to the latest ones on the master branch of the Ionic Team's starter project. It's better to pin things to a specific commit so you know what versions of libraries to expect.
|
I submitted a PR to ionic-team/starters to update |
|
My PR on ionic-team/starters (ionic-team/starters#484) has not been merged so I think we can also closed this one. |
Can you please create a PR for that? |
|
Yes I will do it tomorrow |
No description provided.