Adding Spring Boot API UTs and ITs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running into an issue getting an IT working to mock out the authentication. ITs are not run as part of the build yet, run with: `mvn test -Dtest=HoldingsApiIT`
bdemers
commented
Apr 25, 2018
| @@ -9,24 +9,27 @@ public String getCrypto() { | |||
| return crypto; | |||
| } | |||
|
|
|||
| public void setCrypto(String crypto) { | |||
| public Holding setCrypto(String crypto) { | |||
There was a problem hiding this comment.
@mraible not sure how you feel about this one.
I added it for simplicity, so the test code looks like:
new Holding()
.setCrypto("crypto-1")
.setCurrency("currency-1")
.setAmount("amount-1")but we could accomplish the same thing with an extra constructor or a few extra lines of code.
There was a problem hiding this comment.
I like fluid POJOs, so +1. You'll just have to make sure and explain the change in the post. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.